kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-03 11:25:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

cdr/cdr_adaptive_odbc.c: Fix quoted identifier usage when inserting CDR records

Browse Source 
Commit a24ce38 added support for the use of quoted indentifiers when inserting
CDR records into the database. However, the if statement logic responsible for
determining whether to use those identifiers is reversed, resulting in a
reference to the quoted identifier character buffer which will be null, hence
null terminating the SQL query, resulting in a truncated statement which
fails to execute.

ASTERISK-25263 #close
Reported by: Elazar Broad
Tested by: Elazar Broad

Change-Id: I40da47309b67cc1572207b1515dcc08ec9b1f644
This commit is contained in:
Elazar Broad
2015-07-20 16:59:32 -04:00
committed by Richard Mudgett
parent 6741eedece
commit 293c9f6894
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cdr/cdr_adaptive_odbc.c
View File

@@ -740,9 +740,9 @@ static int odbc_log(struct ast_cdr *cdr)
continue;
}
if (quoted) {
ast_str_append(&sql, 0, "%s%s", separator, entry->name);
} else {
ast_str_append(&sql, 0, "%s%c%s%c", separator, tableptr->quoted_identifiers, entry->name, tableptr->quoted_identifiers);
} else {
ast_str_append(&sql, 0, "%s%s", separator, entry->name);
}
separator = ", ";
} else if (entry->filtervalue