kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-03 19:28:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

AST-2019-005 - translate: Don't assume all frames will have a src.

Browse Source 
This change removes the assumption that a frame will always have
a src set on it. This assumption is incorrect.

Given a scenario where an RTP packet is received with no payload
the resulting audio frame will have no samples. If this frame goes
through a signed linear translation path an interpolated frame can
be created (if generic packet loss concealment is enabled) that has
minimal data on it, including no src. If this frame is given to a
translation path a crash will occur due to the lack of src.

ASTERISK-28499

Change-Id: I024d10dd98207eb8a6b35b59880bcdf1090538f8
This commit is contained in:
Joshua Colp
2019-08-26 09:53:27 -03:00
committed by Gerrit
parent 260969f5ad
commit 2691ee7e10
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
main/translate.c
View File

@@ -403,7 +403,7 @@ static int framein(struct ast_trans_pvt *pvt, struct ast_frame *f)
if (f->samples == 0) {
/* Do not log empty audio frame */
if (strcasecmp(f->src, "ast_prod")) {
if (!f->src || strcasecmp(f->src, "ast_prod")) {
ast_log(LOG_WARNING, "no samples for %s\n", pvt->t->name);
}
}