kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-06 12:36:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

bridge_softmix: Note why ast_stream_topology_set_stream cannot fail.

Browse Source 
This appeared in my audit of ast_stream_topology_set_stream callers
not checking for errors but in this situation the call cannot fail.
Add comment so this can be ignored in the future.

Change-Id: I91d25704859efbe50b8b82cfe1cd3c40ba177c9f
This commit is contained in:
Corey Farrell
2017-11-07 12:49:35 -05:00
parent 38669ac57a
commit 05f557820b
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bridges/bridge_softmix.c
View File

@@ -541,6 +541,8 @@ static int append_all_streams(struct ast_stream_topology *dest,
dest_index++; dest_index++;
if (ast_stream_get_state(stream) == AST_STREAM_STATE_REMOVED) { if (ast_stream_get_state(stream) == AST_STREAM_STATE_REMOVED) {
/* This cannot fail because dest_index - 1 is less than the
* current count in dest. */
ast_stream_topology_set_stream(dest, dest_index - 1, clone); ast_stream_topology_set_stream(dest, dest_index - 1, clone);
added = 1; added = 1;
break; break;