mirror of
https://github.com/MichMich/MagicMirror.git
synced 2025-08-21 12:55:22 +00:00
Make the e2e tests wait for the app to start and close before running next test (#2952)
When trying to debug why the tests broke for https://github.com/MichMich/MagicMirror/pull/2946 I found that the tests does not wait for the app to start and close. So if the startup isn't blocking that would fail. So I added a callback for `close()` too and converted them to promises for the `startApplication()` and `stopApplication()` and updated all the e2e tests to await both. Will try to refactor all these callbacks to promises in a later PR.
This commit is contained in:
@@ -8,7 +8,7 @@ describe("Clock module", () => {
|
||||
|
||||
describe("with default 24hr clock config", () => {
|
||||
beforeAll(async () => {
|
||||
helpers.startApplication("tests/configs/modules/clock/clock_24hr.js");
|
||||
await helpers.startApplication("tests/configs/modules/clock/clock_24hr.js");
|
||||
await helpers.getDocument();
|
||||
});
|
||||
|
||||
@@ -25,7 +25,7 @@ describe("Clock module", () => {
|
||||
|
||||
describe("with default 12hr clock config", () => {
|
||||
beforeAll(async () => {
|
||||
helpers.startApplication("tests/configs/modules/clock/clock_12hr.js");
|
||||
await helpers.startApplication("tests/configs/modules/clock/clock_12hr.js");
|
||||
await helpers.getDocument();
|
||||
});
|
||||
|
||||
@@ -42,7 +42,7 @@ describe("Clock module", () => {
|
||||
|
||||
describe("with showPeriodUpper config enabled", () => {
|
||||
beforeAll(async () => {
|
||||
helpers.startApplication("tests/configs/modules/clock/clock_showPeriodUpper.js");
|
||||
await helpers.startApplication("tests/configs/modules/clock/clock_showPeriodUpper.js");
|
||||
await helpers.getDocument();
|
||||
});
|
||||
|
||||
@@ -54,7 +54,7 @@ describe("Clock module", () => {
|
||||
|
||||
describe("with displaySeconds config disabled", () => {
|
||||
beforeAll(async () => {
|
||||
helpers.startApplication("tests/configs/modules/clock/clock_displaySeconds_false.js");
|
||||
await helpers.startApplication("tests/configs/modules/clock/clock_displaySeconds_false.js");
|
||||
await helpers.getDocument();
|
||||
});
|
||||
|
||||
@@ -66,7 +66,7 @@ describe("Clock module", () => {
|
||||
|
||||
describe("with showTime config disabled", () => {
|
||||
beforeAll(async () => {
|
||||
helpers.startApplication("tests/configs/modules/clock/clock_showTime.js");
|
||||
await helpers.startApplication("tests/configs/modules/clock/clock_showTime.js");
|
||||
await helpers.getDocument();
|
||||
});
|
||||
|
||||
@@ -78,7 +78,7 @@ describe("Clock module", () => {
|
||||
|
||||
describe("with showWeek config enabled", () => {
|
||||
beforeAll(async () => {
|
||||
helpers.startApplication("tests/configs/modules/clock/clock_showWeek.js");
|
||||
await helpers.startApplication("tests/configs/modules/clock/clock_showWeek.js");
|
||||
await helpers.getDocument();
|
||||
});
|
||||
|
||||
@@ -98,7 +98,7 @@ describe("Clock module", () => {
|
||||
|
||||
describe("with analog clock face enabled", () => {
|
||||
beforeAll(async () => {
|
||||
helpers.startApplication("tests/configs/modules/clock/clock_analog.js");
|
||||
await helpers.startApplication("tests/configs/modules/clock/clock_analog.js");
|
||||
await helpers.getDocument();
|
||||
});
|
||||
|
||||
|
Reference in New Issue
Block a user