kenmirrors/MagicMirror
1
0
Fork 0
mirror of https://github.com/MichMich/MagicMirror.git synced 2025-08-21 12:55:22 +00:00
Code Issues Projects Releases Wiki Activity

Make the e2e tests wait for the app to start and close before running next test (#2952)

Browse Source 
When trying to debug why the tests broke for
https://github.com/MichMich/MagicMirror/pull/2946 I found that the tests
does not wait for the app to start and close. So if the startup isn't
blocking that would fail.

So I added a callback for `close()` too and converted them to promises
for the `startApplication()` and `stopApplication()` and updated all the
e2e tests to await both. Will try to refactor all these callbacks to
promises in a later PR.
This commit is contained in:
buxxi
2022-10-29 22:34:17 +02:00
committed by GitHub
parent 7058fc5fd8
commit f25abfd2f8
20 changed files with 189 additions and 168 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/e2e/modules/clock_es_spec.js
View File

@@ -7,7 +7,7 @@ describe("Clock set to spanish language module", () => {
describe("with default 24hr clock config", () => {
beforeAll(async () => {
helpers.startApplication("tests/configs/modules/clock/es/clock_24hr.js");
await helpers.startApplication("tests/configs/modules/clock/es/clock_24hr.js");
await helpers.getDocument();
});
@@ -24,7 +24,7 @@ describe("Clock set to spanish language module", () => {
describe("with default 12hr clock config", () => {
beforeAll(async () => {
helpers.startApplication("tests/configs/modules/clock/es/clock_12hr.js");
await helpers.startApplication("tests/configs/modules/clock/es/clock_12hr.js");
await helpers.getDocument();
});
@@ -41,7 +41,7 @@ describe("Clock set to spanish language module", () => {
describe("with showPeriodUpper config enabled", () => {
beforeAll(async () => {
helpers.startApplication("tests/configs/modules/clock/es/clock_showPeriodUpper.js");
await helpers.startApplication("tests/configs/modules/clock/es/clock_showPeriodUpper.js");
await helpers.getDocument();
});
@@ -53,7 +53,7 @@ describe("Clock set to spanish language module", () => {
describe("with showWeek config enabled", () => {
beforeAll(async () => {
helpers.startApplication("tests/configs/modules/clock/es/clock_showWeek.js");
await helpers.startApplication("tests/configs/modules/clock/es/clock_showWeek.js");
await helpers.getDocument();
});