kenmirrors/MagicMirror
1
0
Fork 0
mirror of https://github.com/MichMich/MagicMirror.git synced 2025-08-21 12:55:22 +00:00
Code Issues Projects Releases Wiki Activity

Make the e2e tests wait for the app to start and close before running next test (#2952)

Browse Source 
When trying to debug why the tests broke for
https://github.com/MichMich/MagicMirror/pull/2946 I found that the tests
does not wait for the app to start and close. So if the startup isn't
blocking that would fail.

So I added a callback for `close()` too and converted them to promises
for the `startApplication()` and `stopApplication()` and updated all the
e2e tests to await both. Will try to refactor all these callbacks to
promises in a later PR.
This commit is contained in:
buxxi
2022-10-29 22:34:17 +02:00
committed by GitHub
parent 7058fc5fd8
commit f25abfd2f8
20 changed files with 189 additions and 168 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tests/e2e/modules/calendar_spec.js
View File

@@ -29,7 +29,7 @@ describe("Calendar module", () => {
describe("Default configuration", () => {
beforeAll(async () => {
helpers.startApplication("tests/configs/modules/calendar/default.js");
await helpers.startApplication("tests/configs/modules/calendar/default.js");
await helpers.getDocument();
});
@@ -44,7 +44,7 @@ describe("Calendar module", () => {
describe("Custom configuration", () => {
beforeAll(async () => {
helpers.startApplication("tests/configs/modules/calendar/custom.js");
await helpers.startApplication("tests/configs/modules/calendar/custom.js");
await helpers.getDocument();
});
@@ -67,7 +67,7 @@ describe("Calendar module", () => {
describe("Recurring event", () => {
beforeAll(async () => {
helpers.startApplication("tests/configs/modules/calendar/recurring.js");
await helpers.startApplication("tests/configs/modules/calendar/recurring.js");
await helpers.getDocument();
});
@@ -83,7 +83,7 @@ describe("Calendar module", () => {
Date.prototype.getTimezoneOffset = () => {
return i * 60;
};
helpers.startApplication("tests/configs/modules/calendar/recurring.js");
await helpers.startApplication("tests/configs/modules/calendar/recurring.js");
await helpers.getDocument();
});
@@ -95,7 +95,7 @@ describe("Calendar module", () => {
describe("Changed port", () => {
beforeAll(async () => {
helpers.startApplication("tests/configs/modules/calendar/changed-port.js");
await helpers.startApplication("tests/configs/modules/calendar/changed-port.js");
serverBasicAuth.listen(8010);
await helpers.getDocument();
});
@@ -111,7 +111,7 @@ describe("Calendar module", () => {
describe("Basic auth", () => {
beforeAll(async () => {
helpers.startApplication("tests/configs/modules/calendar/basic-auth.js");
await helpers.startApplication("tests/configs/modules/calendar/basic-auth.js");
await helpers.getDocument();
});
@@ -122,7 +122,7 @@ describe("Calendar module", () => {
describe("Basic auth by default", () => {
beforeAll(async () => {
helpers.startApplication("tests/configs/modules/calendar/auth-default.js");
await helpers.startApplication("tests/configs/modules/calendar/auth-default.js");
await helpers.getDocument();
});
@@ -133,7 +133,7 @@ describe("Calendar module", () => {
describe("Basic auth backward compatibility configuration: DEPRECATED", () => {
beforeAll(async () => {
helpers.startApplication("tests/configs/modules/calendar/old-basic-auth.js");
await helpers.startApplication("tests/configs/modules/calendar/old-basic-auth.js");
await helpers.getDocument();
});
@@ -144,7 +144,7 @@ describe("Calendar module", () => {
describe("Fail Basic auth", () => {
beforeAll(async () => {
helpers.startApplication("tests/configs/modules/calendar/fail-basic-auth.js");
await helpers.startApplication("tests/configs/modules/calendar/fail-basic-auth.js");
serverBasicAuth.listen(8020);
await helpers.getDocument();
});