kenmirrors/MagicMirror
1
0
Fork 0
mirror of https://github.com/MichMich/MagicMirror.git synced 2025-08-22 05:07:05 +00:00
Code Issues Projects Releases Wiki Activity

Make the e2e tests wait for the app to start and close before running next test (#2952)

Browse Source 
When trying to debug why the tests broke for
https://github.com/MichMich/MagicMirror/pull/2946 I found that the tests
does not wait for the app to start and close. So if the startup isn't
blocking that would fail.

So I added a callback for `close()` too and converted them to promises
for the `startApplication()` and `stopApplication()` and updated all the
e2e tests to await both. Will try to refactor all these callbacks to
promises in a later PR.
This commit is contained in:
buxxi
2022-10-29 22:34:17 +02:00
committed by GitHub
parent 7058fc5fd8
commit f25abfd2f8
20 changed files with 189 additions and 168 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/e2e/ipWhitelist_spec.js
View File

@@ -2,8 +2,8 @@ const helpers = require("./helpers/global-setup");
describe("ipWhitelist directive configuration", () => {
describe("Set ipWhitelist without access", () => {
beforeAll(() => {
helpers.startApplication("tests/configs/noIpWhiteList.js");
beforeAll(async () => {
await helpers.startApplication("tests/configs/noIpWhiteList.js");
});
afterAll(async () => {
await helpers.stopApplication();
@@ -16,8 +16,8 @@ describe("ipWhitelist directive configuration", () => {
});
describe("Set ipWhitelist []", () => {
beforeAll(() => {
helpers.startApplication("tests/configs/empty_ipWhiteList.js");
beforeAll(async () => {
await helpers.startApplication("tests/configs/empty_ipWhiteList.js");
});
afterAll(async () => {
await helpers.stopApplication();