From 2c387f6ae6bb5838642b8e31d4cc8982fa73ea70 Mon Sep 17 00:00:00 2001 From: Michael Teeuw Date: Fri, 1 Apr 2016 10:34:20 +0200 Subject: [PATCH 1/3] visual change --- modules/compliments/compliments.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/compliments/compliments.js b/modules/compliments/compliments.js index 865931cd..33586bad 100644 --- a/modules/compliments/compliments.js +++ b/modules/compliments/compliments.js @@ -113,7 +113,7 @@ Module.register('compliments',{ var compliment = document.createTextNode(complimentText); var wrapper = document.createElement("div"); - wrapper.className = 'thin xlarge'; + wrapper.className = 'thin xlarge bright'; wrapper.appendChild(compliment); return wrapper; From f320f6e9b633f96b7ceac98f1482c83b256659c2 Mon Sep 17 00:00:00 2001 From: Michael Teeuw Date: Fri, 1 Apr 2016 10:44:17 +0200 Subject: [PATCH 2/3] Fix show/hide issue on content update. --- js/main.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/js/main.js b/js/main.js index da5896ac..cf81ca3f 100644 --- a/js/main.js +++ b/js/main.js @@ -422,10 +422,8 @@ var MM = (function() { * argument callback function - Called when the animation is done. */ hideModule: function(module, speed, callback) { - hideModule(module, speed, function() { - module.hidden = true; - if (typeof callback === 'function') { callback(); } - }); + module.hidden = true; + hideModule(module, speed, callback); }, /* showModule(module, speed, callback) From 62fcf8402c4091d6f089d6e1284f233db0d9e725 Mon Sep 17 00:00:00 2001 From: Michael Teeuw Date: Fri, 1 Apr 2016 10:47:16 +0200 Subject: [PATCH 3/3] Add todo. --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index f13fccd6..30af1923 100644 --- a/README.md +++ b/README.md @@ -14,6 +14,9 @@ This version of the Magic Mirror software focusses on a modular plugin system. B ##Todo Things that still have to be implemented or changed. +####Main +- Allow show/hide animations to animate the height. This way the other modules won't jump around. + ####Documentation - Write all the documentation. :)