Add no-param-reassign from eslint (#3089)

While waiting for the easterbunny I cleaned up some bad coding practice
:-)

Very open for comments especially regarding the places I commented
myself...

---------

Co-authored-by: veeck <michael@veeck.de>

modules/default/calendar/calendarfetcherutils.js

@@ -593,15 +593,13 @@ const CalendarFetcherUtils = {
 	 */
 	titleFilterApplies: function (title, filter, useRegex, regexFlags) {
 		if (useRegex) {
+			let regexFilter = filter;
 			// Assume if leading slash, there is also trailing slash
 			if (filter[0] === "/") {
 				// Strip leading and trailing slashes
-				filter = filter.substr(1).slice(0, -1);
+				regexFilter = filter.substr(1).slice(0, -1);
 			}
-
-			filter = new RegExp(filter, regexFlags);
-
-			return filter.test(title);
+			return new RegExp(regexFilter, regexFlags).test(title);
 		} else {
 			return title.includes(filter);
 		}

modules/default/calendar/calendarutils.js

@@ -100,6 +100,7 @@ const CalendarUtils = {
 	 * @returns {string} The transformed title.
 	 */
 	titleTransform: function (title, titleReplace) {
+		let transformedTitle = title;
 		for (let needle in titleReplace) {
 			const replacement = titleReplace[needle];
 
@@ -109,9 +110,9 @@ const CalendarUtils = {
 				needle = new RegExp(regParts[1], regParts[2]);
 			}
 
-			title = title.replace(needle, replacement);
+			transformedTitle = transformedTitle.replace(needle, replacement);
 		}
-		return title;
+		return transformedTitle;
 	}
 };