Add no-param-reassign from eslint (#3089)

While waiting for the easterbunny I cleaned up some bad coding practice
:-)

Very open for comments especially regarding the places I commented
myself...

---------

Co-authored-by: veeck <michael@veeck.de>

modules/default/calendar/calendarfetcherutils.js

@@ -593,15 +593,13 @@ const CalendarFetcherUtils = {
 	 */
 	titleFilterApplies: function (title, filter, useRegex, regexFlags) {
 		if (useRegex) {
+			let regexFilter = filter;
 			// Assume if leading slash, there is also trailing slash
 			if (filter[0] === "/") {
 				// Strip leading and trailing slashes
-				filter = filter.substr(1).slice(0, -1);
+				regexFilter = filter.substr(1).slice(0, -1);
 			}
-
-			filter = new RegExp(filter, regexFlags);
-
-			return filter.test(title);
+			return new RegExp(regexFilter, regexFlags).test(title);
 		} else {
 			return title.includes(filter);
 		}

modules/default/calendar/calendarutils.js

@@ -100,6 +100,7 @@ const CalendarUtils = {
 	 * @returns {string} The transformed title.
 	 */
 	titleTransform: function (title, titleReplace) {
+		let transformedTitle = title;
 		for (let needle in titleReplace) {
 			const replacement = titleReplace[needle];
 
@@ -109,9 +110,9 @@ const CalendarUtils = {
 				needle = new RegExp(regParts[1], regParts[2]);
 			}
 
-			title = title.replace(needle, replacement);
+			transformedTitle = transformedTitle.replace(needle, replacement);
 		}
-		return title;
+		return transformedTitle;
 	}
 };
 

modules/default/newsfeed/newsfeedfetcher.js

@@ -25,12 +25,13 @@ const NodeHelper = require("node_helper");
 const NewsfeedFetcher = function (url, reloadInterval, encoding, logFeedWarnings, useCorsProxy) {
 	let reloadTimer = null;
 	let items = [];
+	let reloadIntervalMS = reloadInterval;
 
 	let fetchFailedCallback = function () {};
 	let itemsReceivedCallback = function () {};
 
-	if (reloadInterval < 1000) {
-		reloadInterval = 1000;
+	if (reloadIntervalMS < 1000) {
+		reloadIntervalMS = 1000;
 	}
 
 	/* private methods */
@@ -89,9 +90,9 @@ const NewsfeedFetcher = function (url, reloadInterval, encoding, logFeedWarnings
 			try {
 				// 86400000 = 24 hours is mentioned in the docs as maximum value:
 				const ttlms = Math.min(minutes * 60 * 1000, 86400000);
-				if (ttlms > reloadInterval) {
-					reloadInterval = ttlms;
-					Log.info(`Newsfeed-Fetcher: reloadInterval set to ttl=${reloadInterval} for url ${url}`);
+				if (ttlms > reloadIntervalMS) {
+					reloadIntervalMS = ttlms;
+					Log.info(`Newsfeed-Fetcher: reloadInterval set to ttl=${reloadIntervalMS} for url ${url}`);
 				}
 			} catch (error) {
 				Log.warn(`Newsfeed-Fetcher: feed ttl is no valid integer=${minutes} for url ${url}`);
@@ -129,7 +130,7 @@ const NewsfeedFetcher = function (url, reloadInterval, encoding, logFeedWarnings
 		clearTimeout(reloadTimer);
 		reloadTimer = setTimeout(function () {
 			fetchNews();
-		}, reloadInterval);
+		}, reloadIntervalMS);
 	};
 
 	/* public methods */
@@ -140,8 +141,8 @@ const NewsfeedFetcher = function (url, reloadInterval, encoding, logFeedWarnings
 	 * @param {number} interval Interval for the update in milliseconds.
 	 */
 	this.setReloadInterval = function (interval) {
-		if (interval > 1000 && interval < reloadInterval) {
-			reloadInterval = interval;
+		if (interval > 1000 && interval < reloadIntervalMS) {
+			reloadIntervalMS = interval;
 		}
 	};
 

modules/default/utils.js

@@ -10,12 +10,14 @@
  */
 async function performWebRequest(url, type = "json", useCorsProxy = false, requestHeaders = undefined, expectedResponseHeaders = undefined) {
 	const request = {};
+	let requestUrl;
 	if (useCorsProxy) {
-		url = getCorsUrl(url, requestHeaders, expectedResponseHeaders);
+		requestUrl = getCorsUrl(url, requestHeaders, expectedResponseHeaders);
 	} else {
+		requestUrl = url;
 		request.headers = getHeadersToSend(requestHeaders);
 	}
-	const response = await fetch(url, request);
+	const response = await fetch(requestUrl, request);
 	const data = await response.text();
 
 	if (type === "xml") {

modules/default/weather/providers/yr.js

@@ -110,13 +110,15 @@ WeatherProvider.register("yr", {
 			this.getWeatherDataFromYr(weatherData?.downloadedAt)
 				.then((weatherData) => {
 					Log.debug("Got weather data from yr.");
+					let data;
 					if (weatherData) {
 						this.cacheWeatherData(weatherData);
+						data = weatherData;
 					} else {
 						//Undefined if unchanged
-						weatherData = this.getWeatherDataFromCache();
+						data = this.getWeatherDataFromCache();
 					}
-					resolve(weatherData);
+					resolve(data);
 				})
 				.catch((err) => {
 					Log.error(err);
@@ -266,14 +268,14 @@ WeatherProvider.register("yr", {
 			this.getStellarDataFromYr(today, 2)
 				.then((stellarData) => {
 					if (stellarData) {
-						stellarData = {
+						const data = {
 							today: stellarData
 						};
-						stellarData.tomorrow = Object.assign({}, stellarData.today);
-						stellarData.today.date = today;
-						stellarData.tomorrow.date = tomorrow;
-						this.cacheStellarData(stellarData);
-						resolve(stellarData);
+						data.tomorrow = Object.assign({}, data.today);
+						data.today.date = today;
+						data.tomorrow.date = tomorrow;
+						this.cacheStellarData(data);
+						resolve(data);
 					} else {
 						Log.error(`Something went wrong when fetching stellar data. Responses: ${stellarData}`);
 						reject(stellarData);

modules/default/weather/weather.js

@@ -218,29 +218,30 @@ Module.register("weather", {
 		this.nunjucksEnvironment().addFilter(
 			"unit",
 			function (value, type, valueUnit) {
+				let formattedValue;
 				if (type === "temperature") {
-					value = `${this.roundValue(WeatherUtils.convertTemp(value, this.config.tempUnits))}°`;
+					formattedValue = `${this.roundValue(WeatherUtils.convertTemp(value, this.config.tempUnits))}°`;
 					if (this.config.degreeLabel) {
 						if (this.config.tempUnits === "metric") {
-							value += "C";
+							formattedValue += "C";
 						} else if (this.config.tempUnits === "imperial") {
-							value += "F";
+							formattedValue += "F";
 						} else {
-							value += "K";
+							formattedValue += "K";
 						}
 					}
 				} else if (type === "precip") {
 					if (value === null || isNaN(value) || value === 0 || value.toFixed(2) === "0.00") {
-						value = "";
+						formattedValue = "";
 					} else {
-						value = WeatherUtils.convertPrecipitationUnit(value, valueUnit, this.config.units);
+						formattedValue = WeatherUtils.convertPrecipitationUnit(value, valueUnit, this.config.units);
 					}
 				} else if (type === "humidity") {
-					value += "%";
+					formattedValue = `${value}%`;
 				} else if (type === "wind") {
-					value = WeatherUtils.convertWind(value, this.config.windUnits);
+					formattedValue = WeatherUtils.convertWind(value, this.config.windUnits);
 				}
-				return value;
+				return formattedValue;
 			}.bind(this)
 		);
 

modules/default/weather/weatherprovider.js

@@ -154,17 +154,17 @@ WeatherProvider.register = function (providerIdentifier, providerDetails) {
  * @returns {object} The new weather provider
  */
 WeatherProvider.initialize = function (providerIdentifier, delegate) {
-	providerIdentifier = providerIdentifier.toLowerCase();
+	const pi = providerIdentifier.toLowerCase();
 
-	const provider = new WeatherProvider.providers[providerIdentifier]();
+	const provider = new WeatherProvider.providers[pi]();
 	const config = Object.assign({}, provider.defaults, delegate.config);
 
 	provider.delegate = delegate;
 	provider.setConfig(config);
 
-	provider.providerIdentifier = providerIdentifier;
+	provider.providerIdentifier = pi;
 	if (!provider.providerName) {
-		provider.providerName = providerIdentifier;
+		provider.providerName = pi;
 	}
 
 	return provider;

modules/default/weather/weatherutils.js

@@ -32,17 +32,19 @@ const WeatherUtils = {
 	 * @returns {string} - A string with tha value and a unit postfix.
 	 */
 	convertPrecipitationUnit(value, valueUnit, outputUnit) {
+		let convertedValue = value;
+		let conversionUnit = valueUnit;
 		if (outputUnit === "imperial") {
-			if (valueUnit && valueUnit.toLowerCase() === "cm") value = value * 0.3937007874;
-			else value = value * 0.03937007874;
-			valueUnit = "in";
+			if (valueUnit && valueUnit.toLowerCase() === "cm") convertedValue = convertedValue * 0.3937007874;
+			else convertedValue = convertedValue * 0.03937007874;
+			conversionUnit = "in";
 		} else {
-			valueUnit = valueUnit ? valueUnit : "mm";
+			conversionUnit = valueUnit ? valueUnit : "mm";
 		}
 
-		if (valueUnit === "%") return `${value.toFixed(0)} ${valueUnit}`;
+		if (valueUnit === "%") return `${convertedValue.toFixed(0)} ${conversionUnit}`;
 
-		return `${value.toFixed(2)} ${valueUnit}`;
+		return `${convertedValue.toFixed(2)} ${conversionUnit}`;
 	},
 
 	/**