kenmirrors/MagicMirror
1
0
Fork 0
mirror of https://github.com/MichMich/MagicMirror.git synced 2025-08-22 13:09:26 +00:00
Code Issues Projects Releases Wiki Activity

Fix loading of multiple instances of node_helper when multiple instances of a module are in config.js (#3517)

Browse Source 
adds a check for already loaded/loading for node helper of a each
module, only does once

fixes #3502
This commit is contained in:
sam detweiler
2024-08-04 14:28:20 -05:00
committed by GitHub
parent 76d8f98969
commit 780e4e2e06
2 changed files with 18 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
js/app.js
View File

@@ -9,6 +9,7 @@ const Log = require("logger");
const Server = require(`${__dirname}/server`);
const Utils = require(`${__dirname}/utils`);
const defaultModules = require(`${__dirname}/../modules/default/defaultmodules`);
const helperhash = {};
// Get version number.
global.version = require(`${__dirname}/../package.json`).version;
@@ -175,14 +176,23 @@ function App () {
const helperPath = `${moduleFolder}/node_helper.js`;
let loadHelper = true;
try {
fs.accessSync(helperPath, fs.R_OK);
} catch (e) {
loadHelper = false;
Log.log(`No helper found for module: ${moduleName}.`);
}
// find out if helper was loaded before for this module
// only load it once
let loadHelper = helperhash[moduleName] ? false : true;
// if this is the 1st time for this module, check for helper file
// otherwise, its already loaded, if found
if (loadHelper) {
try {
fs.accessSync(helperPath, fs.R_OK);
// indicte we found one to load for this module
helperhash[moduleName] = true;
} catch (e) {
loadHelper = false;
Log.log(`No helper found for module: ${moduleName}.`);
}
}
// if the helper was found, AND needed 1st time
if (loadHelper) {
const Module = require(helperPath);
let m = new Module();