mirror of
https://github.com/MichMich/MagicMirror.git
synced 2025-08-21 12:55:22 +00:00
Enable and apply ESLint Jest rules (#3270)
Jest was in the plugin array of the ESLint configuration, but no rules
were enabled. So ESLint hasn't checked any Jest rules yet.
So I activated the recommended Jest rules and added a few more. Then I
fixed the issues (mostly automatically). I have deactivated the rules
"jest/expect-expect" and "jest/no-done-callback" for the time being, as
they would have entailed major changes. I didn't want to make the PR too
big.
I'm not a Jest expert, but the changes so far look good to me. What do
you think of that @khassel? 🙂
This commit is contained in:
committed by
GitHub
parent
679a413788
commit
7098f1e41f
@@ -12,8 +12,8 @@ describe("Electron app environment", () => {
|
||||
|
||||
it("should open browserwindow", async () => {
|
||||
const module = await helpers.getElement("#module_0_helloworld");
|
||||
expect(await module.textContent()).toContain("Test Display Header");
|
||||
expect(global.electronApp.windows().length).toBe(1);
|
||||
await expect(module.textContent()).resolves.toContain("Test Display Header");
|
||||
expect(global.electronApp.windows()).toHaveLength(1);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -29,7 +29,7 @@ describe("Development console tests", () => {
|
||||
it("should open browserwindow and dev console", async () => {
|
||||
while (global.electronApp.windows().length < 2) await events.once(global.electronApp, "window");
|
||||
const pageArray = await global.electronApp.windows();
|
||||
expect(pageArray.length).toBe(2);
|
||||
expect(pageArray).toHaveLength(2);
|
||||
for (const page of pageArray) {
|
||||
expect(["MagicMirror²", "DevTools"]).toContain(await page.title());
|
||||
}
|
||||
|
Reference in New Issue
Block a user