Revise require imports (#3071)

- order (external first)
- remove superfluous file extensions
- new line after imports
- deconstruct (only one time (in `check_config.js`))
- fix path (only one time (in `global-setup.js`))

tests/e2e/helpers/global-setup.js

@@ -13,7 +13,7 @@ exports.startApplication = async (configFilename, exec) => {
 		process.env.MM_CONFIG_FILE = configFilename;
 	}
 	if (exec) exec;
-	global.app = require("app.js");
+	global.app = require("../../../js/app");
 
 	return global.app.start();
 };

tests/e2e/helpers/weather-functions.js

@@ -1,5 +1,5 @@
-const helpers = require("./global-setup");
 const { injectMockData } = require("../../utils/weather_mocker");
+const helpers = require("./global-setup");
 
 exports.getText = async (element, result) => {
 	const elem = await helpers.waitForElement(element);

tests/e2e/modules/calendar_spec.js

@@ -1,5 +1,5 @@
 const helpers = require("../helpers/global-setup");
-const serverBasicAuth = require("../helpers/basic-auth.js");
+const serverBasicAuth = require("../helpers/basic-auth");
 
 describe("Calendar module", () => {
 	/**

tests/e2e/modules/clock_spec.js

@@ -1,5 +1,5 @@
-const helpers = require("../helpers/global-setup");
 const moment = require("moment");
+const helpers = require("../helpers/global-setup");
 
 describe("Clock module", () => {
 	afterAll(async () => {

tests/e2e/translations_spec.js

@@ -1,10 +1,10 @@
 const fs = require("fs");
 const path = require("path");
-const translations = require("../../translations/translations.js");
 const helmet = require("helmet");
 const { JSDOM } = require("jsdom");
 const express = require("express");
 const sinon = require("sinon");
+const translations = require("../../translations/translations");
 
 describe("Translations", () => {
 	let server;

tests/electron/env_spec.js

@@ -1,5 +1,5 @@
-const helpers = require("./helpers/global-setup");
 const events = require("events");
+const helpers = require("./helpers/global-setup");
 
 describe("Electron app environment", () => {
 	beforeEach(async () => {

tests/electron/helpers/weather-setup.js

@@ -1,5 +1,5 @@
-const helpers = require("./global-setup");
 const { injectMockData } = require("../../utils/weather_mocker");
+const helpers = require("./global-setup");
 
 exports.getText = async (element, result) => {
 	const elem = await helpers.getElement(element);

tests/unit/classes/translator_spec.js

@@ -2,6 +2,7 @@ const path = require("path");
 const helmet = require("helmet");
 const { JSDOM } = require("jsdom");
 const express = require("express");
+
 const sockets = new Set();
 
 describe("Translator", () => {

tests/unit/classes/utils_spec.js

@@ -1,5 +1,5 @@
-const Utils = require("../../../js/utils.js");
 const colors = require("colors/safe");
+const Utils = require("../../../js/utils");
 
 describe("Utils", () => {
 	describe("colors", () => {

tests/unit/functions/calendar_spec.js

@@ -10,7 +10,7 @@ describe("Functions into modules/default/calendar/calendar.js", () => {
 
 	beforeAll(() => {
 		// load calendar.js
-		require("../../../modules/default/calendar/calendar.js");
+		require("../../../modules/default/calendar/calendar");
 	});
 
 	describe("capFirst", () => {

tests/unit/functions/weather_object_spec.js

@@ -1,5 +1,5 @@
-const WeatherObject = require("../../../modules/default/weather/weatherobject.js");
-const WeatherUtils = require("../../../modules/default/weather/weatherutils.js");
+const WeatherObject = require("../../../modules/default/weather/weatherobject");
+const WeatherUtils = require("../../../modules/default/weather/weatherutils");
 
 global.moment = require("moment-timezone");
 global.SunCalc = require("suncalc");

tests/unit/modules/default/utils_spec.js

@@ -1,4 +1,5 @@
-const { performWebRequest } = require("../../../../modules/default/utils.js");
+const { performWebRequest } = require("../../../../modules/default/utils");
+
 const nodeVersion = process.version.match(/^v(\d+)\.*/)[1];
 
 describe("Utils tests", () => {

tests/unit/modules/default/weather/weather_utils_spec.js

@@ -1,4 +1,4 @@
-const weather = require("../../../../../modules/default/weather/weatherutils.js");
+const weather = require("../../../../../modules/default/weather/weatherutils");
 
 describe("Weather utils tests", () => {
 	describe("convertPrecipitationUnit tests", () => {

tests/utils/weather_mocker.js

@@ -1,6 +1,6 @@
-const _ = require("lodash");
 const fs = require("fs");
 const path = require("path");
+const _ = require("lodash");
 
 /**
  * @param {string} type what data to read, can be "current" "forecast" or "hourly