From 4fecffc3dfd4ad367255878eda2165564b4d0fd4 Mon Sep 17 00:00:00 2001 From: Karsten Hassel Date: Mon, 31 Oct 2022 14:27:31 +0100 Subject: [PATCH] Add Collaboration.md (#2954) As already discussed here the first shot of the collaboration rules. We can discuss this in the comments until ready to merge. Co-authored-by: Veeck --- CHANGELOG.md | 1 + Collaboration.md | 12 ++++++++++++ 2 files changed, 13 insertions(+) create mode 100644 Collaboration.md diff --git a/CHANGELOG.md b/CHANGELOG.md index a3fee91d..516e499a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,7 @@ Special thanks to: @rejas, @sdetweil, @MagMar94 - Added hourlyWeather functionality to Weather.gov weather provider - Removed weatherEndpoint definition from weathergov.js (not used) - Added css class names "today" and "tomorrow" for default calendar +- Added Collaboration.md - Added new github action for dependency review (#2862) ### Removed diff --git a/Collaboration.md b/Collaboration.md new file mode 100644 index 00000000..6be3fecb --- /dev/null +++ b/Collaboration.md @@ -0,0 +1,12 @@ +This document describes how collaborators of this repository should work together. + +## Pull Requests + +- never merge your own PR's +- never merge without someone having approved (approving and merging from same person is allowed) +- wait for all approvals requested (or the author decides something different in the comments) + +## Issues + +- "real" Issues are closed if the problem is solved and the fix is released +- unrelated Issues (e.g. related to a foreign module) are closed immediately with a comment to open an issue in the module repository or to discuss this further in the forum or discord