From 4e7b68a69d4db7063027f16e47155177ee883492 Mon Sep 17 00:00:00 2001 From: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com> Date: Sat, 23 Dec 2023 07:27:02 +0100 Subject: [PATCH] Remove some unused variables (#3301) I have noticed unused variables that seem superfluous. --- CHANGELOG.md | 1 + js/logger.js | 2 +- modules/default/calendar/calendar.js | 2 +- modules/default/calendar/calendarfetcherutils.js | 2 -- modules/default/weather/providers/openmeteo.js | 2 +- tests/e2e/serveronly_spec.js | 2 -- 6 files changed, 4 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 93250954..9fc22833 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,6 +21,7 @@ _This release is scheduled to be released on 2024-01-01._ - Removed Codecov workflow (not working anymore, other workflow required) (#3107) - Removed titleReplace from calendar, replaced + extended by customEvents (backward compatibility included) (#3249) - Removed failing unit test (#3254) +- Removed some unused variables ### Updated diff --git a/js/logger.js b/js/logger.js index e6a244cb..9ccded66 100644 --- a/js/logger.js +++ b/js/logger.js @@ -50,7 +50,7 @@ logLevel.setLogLevel = function (newLevel) { if (newLevel) { - Object.keys(logLevel).forEach(function (key, index) { + Object.keys(logLevel).forEach(function (key) { if (!newLevel.includes(key.toLocaleUpperCase())) { logLevel[key] = function () {}; } diff --git a/modules/default/calendar/calendar.js b/modules/default/calendar/calendar.js index cc80ea56..7c06a124 100644 --- a/modules/default/calendar/calendar.js +++ b/modules/default/calendar/calendar.js @@ -1,4 +1,4 @@ -/* global CalendarUtils, cloneObject */ +/* global CalendarUtils */ /* MagicMirror² * Module: Calendar diff --git a/modules/default/calendar/calendarfetcherutils.js b/modules/default/calendar/calendarfetcherutils.js index 14203289..35b43cbc 100644 --- a/modules/default/calendar/calendarfetcherutils.js +++ b/modules/default/calendar/calendarfetcherutils.js @@ -248,7 +248,6 @@ const CalendarFetcherUtils = { if (typeof event.rrule !== "undefined" && event.rrule !== null && !isFacebookBirthday) { const rule = event.rrule; - let addedEvents = 0; const pastMoment = moment(past); const futureMoment = moment(future); @@ -442,7 +441,6 @@ const CalendarFetcherUtils = { if (showRecurrence === true) { Log.debug(`saving event: ${description}`); - addedEvents++; newEvents.push({ title: recurrenceTitle, startDate: (adjustDays ? (adjustDays > 0 ? startDate.add(adjustDays, "hours") : startDate.subtract(Math.abs(adjustDays), "hours")) : startDate).format("x"), diff --git a/modules/default/weather/providers/openmeteo.js b/modules/default/weather/providers/openmeteo.js index 79d7d1fa..fcee5557 100644 --- a/modules/default/weather/providers/openmeteo.js +++ b/modules/default/weather/providers/openmeteo.js @@ -397,7 +397,7 @@ WeatherProvider.register("openmeteo", { generateWeatherObjectsFromForecast(weathers) { const days = []; - weathers.daily.forEach((weather, i) => { + weathers.daily.forEach((weather) => { const currentWeather = new WeatherObject(); currentWeather.date = weather.time; diff --git a/tests/e2e/serveronly_spec.js b/tests/e2e/serveronly_spec.js index 82d0429b..9a6f29ba 100644 --- a/tests/e2e/serveronly_spec.js +++ b/tests/e2e/serveronly_spec.js @@ -1,5 +1,3 @@ -const helpers = require("./helpers/global-setup"); - const delay = (time) => { return new Promise((resolve) => setTimeout(resolve, time)); };