kenmirrors/MagicMirror
1
0
Fork 0
mirror of https://github.com/MichMich/MagicMirror.git synced 2025-08-21 04:45:17 +00:00
Code Issues Projects Releases Wiki Activity

Add tests for some weather utils (#3103)

Browse Source 
Co-authored-by: veeck <michael@veeck.de>
This commit is contained in:
Veeck
2023-05-15 21:04:50 +02:00
committed by GitHub
parent 83315f1fed
commit 432d900ecd
7 changed files with 227 additions and 357 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
modules/default/weather/providers/openweathermap.js
View File

@@ -434,6 +434,7 @@ WeatherProvider.register("openweathermap", {
} else if (this.firstEvent && this.firstEvent.location) {
params += `q=${this.firstEvent.location}`;
} else {
// TODO hide doesnt exist!
this.hide(this.config.animationSpeed, { lockString: this.identifier });
return;
}

4
modules/default/weather/weatherutils.js
View File

@@ -30,6 +30,8 @@ const WeatherUtils = {
* @returns {string} - A string with tha value and a unit postfix.
*/
convertPrecipitationUnit(value, valueUnit, outputUnit) {
if (valueUnit === "%") return `${value.toFixed(0)} ${valueUnit}`;
let convertedValue = value;
let conversionUnit = valueUnit;
if (outputUnit === "imperial") {
@@ -40,8 +42,6 @@ const WeatherUtils = {
conversionUnit = valueUnit ? valueUnit : "mm";
}
if (valueUnit === "%") return `${convertedValue.toFixed(0)} ${conversionUnit}`;
return `${convertedValue.toFixed(2)} ${conversionUnit}`;
},