From 93c07b2b1e2e4218d17ceead43b63509b6beb7e0 Mon Sep 17 00:00:00 2001 From: Tino Ziegler Date: Wed, 18 Jan 2017 15:56:12 +0100 Subject: [PATCH 1/3] =?UTF-8?q?Fix:=20check=20if=20temperature=20is=20defi?= =?UTF-8?q?ned=20(0=C2=B0)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- modules/default/currentweather/currentweather.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/default/currentweather/currentweather.js b/modules/default/currentweather/currentweather.js index e92550ea..37b054a9 100644 --- a/modules/default/currentweather/currentweather.js +++ b/modules/default/currentweather/currentweather.js @@ -296,7 +296,7 @@ Module.register("currentweather",{ */ processWeather: function(data) { - if (!data || !data.main || !data.main.temp) { + if (!data || !data.main || typeof data.main.temp === 'undefined') { // Did not receive usable new data. // Maybe this needs a better check? return; From 56413ee94eca749171fad83ccd95aabc189e02e5 Mon Sep 17 00:00:00 2001 From: Tino Ziegler Date: Wed, 18 Jan 2017 16:04:02 +0100 Subject: [PATCH 2/3] added fix --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b9551b79..544ce189 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,9 @@ All notable changes to this project will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org/). +## Fixed +- Module currentWeather: check if temperature is defined + ## [2.1.0] - 2016-12-31 **Note:** This update uses new dependencies. Please update using the following command: `git pull && npm install` From 222e4154a1bc303c8c37a0c25abfbc16bb89e0f0 Mon Sep 17 00:00:00 2001 From: Tino Ziegler Date: Thu, 19 Jan 2017 09:11:33 +0100 Subject: [PATCH 3/3] changed to double quotes --- modules/default/currentweather/currentweather.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/default/currentweather/currentweather.js b/modules/default/currentweather/currentweather.js index 37b054a9..135af54a 100644 --- a/modules/default/currentweather/currentweather.js +++ b/modules/default/currentweather/currentweather.js @@ -296,7 +296,7 @@ Module.register("currentweather",{ */ processWeather: function(data) { - if (!data || !data.main || typeof data.main.temp === 'undefined') { + if (!data || !data.main || typeof data.main.temp === "undefined") { // Did not receive usable new data. // Maybe this needs a better check? return;