Release 2.22.0 (#2983)

## [2.22.0] - 2023-01-01

Thanks to: @angeldeejay, @buxxi, @dariom, @dWoolridge,
@KristjanESPERANTO, @MagMar94, @naveensrinivasan, @retroflex, @SkySails
and @Tom.

Special thanks to @khassel, @rejas and @sdetweil for taking over most
(if not all) of the work on this release as project collaborators. This
version would not be there without their effort. Thank you!

### Added

- Added test for remoteFile option in compliments module
- Added hourlyWeather functionality to Weather.gov weather provider
- Removed weatherEndpoint definition from weathergov.js (not used)
- Added css class names "today" and "tomorrow" for default calendar
- Added Collaboration.md
- Added new github action for dependency review (#2862)
- Added a WeatherProvider for Open-Meteo
- Added Yr as a weather provider
- Added config options "ignoreXOriginHeader" and
"ignoreContentSecurityPolicy"

### Removed

- Removed usage of internal fetch function of node until it is more
stable

### Updated

- Cleaned up test directory (#2937) and jest config (#2959)
- Wait for all modules to start before declaring the system ready
(#2487)
- Updated e2e tests (moved `done()` in helper functions) and use es6
syntax in all tests
- Updated da translation
- Rework weather module
- Make sure smhi provider api only gets a maximum of 6 digits
coordinates (#2955)
  - Use fetch instead of XMLHttpRequest in weatherprovider (#2935)
  - Reworked how weatherproviders handle units (#2849)
  - Use unix() method for parsing times, fix suntimes on the way (#2950)
  - Refactor conversion functions into utils class (#2958)
- The `cors`-method in `server.js` now supports sending and recieving
HTTP headers
- Replace `…` by `…`
- Cleanup compliments module
- Updated dependencies including electron to v22 (#2903)

### Fixed

- Correctly show apparent temperature in SMHI weather provider
- Ensure updatenotification module isn't shown when local is _ahead_ of
remote
- Handle node_helper errors during startup (#2944)
- Possibility to change FontAwesome class in calendar, so icons like
`fab fa-facebook-square` works.
- Fix cors problems with newsfeed articles (as far as possible), allow
disabling cors per feed with option `useCorsProxy: false` (#2840)
- Tests not waiting for the application to start and stop before
starting the next test
- Fix electron tests failing sometimes in github workflow
- Fixed gap in clock module when displayed on the left side with
displayType=digital
- Fixed playwright issue by upgrading to v1.29.1 (#2969)

Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>
Co-authored-by: Karsten Hassel <hassel@gmx.de>
Co-authored-by: Malte Hallström <46646495+SkySails@users.noreply.github.com>
Co-authored-by: Veeck <github@veeck.de>
Co-authored-by: veeck <michael@veeck.de>
Co-authored-by: dWoolridge <dwoolridge@charter.net>
Co-authored-by: Johan <jojjepersson@yahoo.se>
Co-authored-by: Dario Mratovich <dario_mratovich@hotmail.com>
Co-authored-by: Dario Mratovich <dario.mratovich@outlook.com>
Co-authored-by: Magnus <34011212+MagMar94@users.noreply.github.com>
Co-authored-by: Naveen <172697+naveensrinivasan@users.noreply.github.com>
Co-authored-by: buxxi <buxxi@omfilm.net>
Co-authored-by: Thomas Hirschberger <47733292+Tom-Hirschberger@users.noreply.github.com>
Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com>
Co-authored-by: Andrés Vanegas Jiménez <142350+angeldeejay@users.noreply.github.com>

tests/e2e/translations_spec.js

@@ -6,13 +6,13 @@ const { JSDOM } = require("jsdom");
 const express = require("express");
 const sinon = require("sinon");
 
-describe("Translations", function () {
+describe("Translations", () => {
 	let server;
 
-	beforeAll(function () {
+	beforeAll(() => {
 		const app = express();
 		app.use(helmet());
-		app.use(function (req, res, next) {
+		app.use((req, res, next) => {
 			res.header("Access-Control-Allow-Origin", "*");
 			next();
 		});
@@ -21,11 +21,11 @@ describe("Translations", function () {
 		server = app.listen(3000);
 	});
 
-	afterAll(function () {
+	afterAll(() => {
 		server.close();
 	});
 
-	it("should have a translation file in the specified path", function () {
+	it("should have a translation file in the specified path", () => {
 		for (let language in translations) {
 			const file = fs.statSync(translations[language]);
 			expect(file.isFile()).toBe(true);
@@ -37,7 +37,7 @@ describe("Translations", function () {
 
 		beforeEach(() => {
 			dom = new JSDOM(
-				`<script>var Translator = {}; var Log = {log: function(){}}; var config = {language: 'de'};</script>\
+				`<script>var Translator = {}; var Log = {log: () => {}}; var config = {language: 'de'};</script>\
 					<script src="file://${path.join(__dirname, "..", "..", "js", "class.js")}"></script>\
 					<script src="file://${path.join(__dirname, "..", "..", "js", "module.js")}"></script>`,
 				{ runScripts: "dangerously", resources: "usable" }
@@ -45,7 +45,7 @@ describe("Translations", function () {
 		});
 
 		it("should load translation file", (done) => {
-			dom.window.onload = async function () {
+			dom.window.onload = async () => {
 				const { Translator, Module, config } = dom.window;
 				config.language = "en";
 				Translator.load = sinon.stub().callsFake((_m, _f, _fb, callback) => callback());
@@ -65,7 +65,7 @@ describe("Translations", function () {
 		});
 
 		it("should load translation + fallback file", (done) => {
-			dom.window.onload = async function () {
+			dom.window.onload = async () => {
 				const { Translator, Module } = dom.window;
 				Translator.load = sinon.stub().callsFake((_m, _f, _fb, callback) => callback());
 
@@ -85,7 +85,7 @@ describe("Translations", function () {
 		});
 
 		it("should load translation fallback file", (done) => {
-			dom.window.onload = async function () {
+			dom.window.onload = async () => {
 				const { Translator, Module, config } = dom.window;
 				config.language = "--";
 				Translator.load = sinon.stub().callsFake((_m, _f, _fb, callback) => callback());
@@ -105,7 +105,7 @@ describe("Translations", function () {
 		});
 
 		it("should load no file", (done) => {
-			dom.window.onload = async function () {
+			dom.window.onload = async () => {
 				const { Translator, Module } = dom.window;
 				Translator.load = sinon.stub();
 
@@ -130,18 +130,18 @@ describe("Translations", function () {
 		}
 	};
 
-	describe("Parsing language files through the Translator class", function () {
+	describe("Parsing language files through the Translator class", () => {
 		for (let language in translations) {
-			it(`should parse ${language}`, function (done) {
+			it(`should parse ${language}`, (done) => {
 				const dom = new JSDOM(
-					`<script>var translations = ${JSON.stringify(translations)}; var Log = {log: function(){}};</script>\
+					`<script>var translations = ${JSON.stringify(translations)}; var Log = {log: () => {}};</script>\
 					<script src="file://${path.join(__dirname, "..", "..", "js", "translator.js")}">`,
 					{ runScripts: "dangerously", resources: "usable" }
 				);
-				dom.window.onload = function () {
+				dom.window.onload = () => {
 					const { Translator } = dom.window;
 
-					Translator.load(mmm, translations[language], false, function () {
+					Translator.load(mmm, translations[language], false, () => {
 						expect(typeof Translator.translations[mmm.name]).toBe("object");
 						expect(Object.keys(Translator.translations[mmm.name]).length).toBeGreaterThanOrEqual(1);
 						done();
@@ -151,27 +151,27 @@ describe("Translations", function () {
 		}
 	});
 
-	describe("Same keys", function () {
+	describe("Same keys", () => {
 		let base;
 		let missing = [];
 
-		beforeAll(function (done) {
+		beforeAll((done) => {
 			const dom = new JSDOM(
-				`<script>var translations = ${JSON.stringify(translations)}; var Log = {log: function(){}};</script>\
+				`<script>var translations = ${JSON.stringify(translations)}; var Log = {log: () => {}};</script>\
 					<script src="file://${path.join(__dirname, "..", "..", "js", "translator.js")}">`,
 				{ runScripts: "dangerously", resources: "usable" }
 			);
-			dom.window.onload = function () {
+			dom.window.onload = () => {
 				const { Translator } = dom.window;
 
-				Translator.load(mmm, translations.de, false, function () {
+				Translator.load(mmm, translations.de, false, () => {
 					base = Object.keys(Translator.translations[mmm.name]).sort();
 					done();
 				});
 			};
 		});
 
-		afterAll(function () {
+		afterAll(() => {
 			console.log(missing);
 		});
 
@@ -182,32 +182,32 @@ describe("Translations", function () {
 				continue;
 			}
 
-			describe(`Translation keys of ${language}`, function () {
+			describe(`Translation keys of ${language}`, () => {
 				let keys;
 
-				beforeAll(function (done) {
+				beforeAll((done) => {
 					const dom = new JSDOM(
-						`<script>var translations = ${JSON.stringify(translations)}; var Log = {log: function(){}};</script>\
+						`<script>var translations = ${JSON.stringify(translations)}; var Log = {log: () => {}};</script>\
 					<script src="file://${path.join(__dirname, "..", "..", "js", "translator.js")}">`,
 						{ runScripts: "dangerously", resources: "usable" }
 					);
-					dom.window.onload = function () {
+					dom.window.onload = () => {
 						const { Translator } = dom.window;
 
-						Translator.load(mmm, translations[language], false, function () {
+						Translator.load(mmm, translations[language], false, () => {
 							keys = Object.keys(Translator.translations[mmm.name]).sort();
 							done();
 						});
 					};
 				});
 
-				it(`${language} keys should be in base`, function () {
-					keys.forEach(function (key) {
+				it(`${language} keys should be in base`, () => {
+					keys.forEach((key) => {
 						expect(base.indexOf(key)).toBeGreaterThanOrEqual(0);
 					});
 				});
 
-				it(`${language} should contain all base keys`, function () {
+				it(`${language} should contain all base keys`, () => {
 					// TODO: when all translations are fixed, use
 					// expect(keys).toEqual(base);
 					// instead of the try-catch-block